Walkthrough

The login options configuration for kubeconfig now enables insecure TLS when either the InsecureTLS flag is set or an existing insecure cluster is detected. Certificate error handling has been simplified to consistently prompt users for insecure TLS acceptance before retrying the connection.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify hasExistingInsecureCluster() function exists and returns expected boolean values
• Confirm the simplified certificate error handling path doesn't remove necessary security checks or bypass intended validations
• Review the implications of always prompting for insecure TLS versus conditional prompting in the prior implementation
• Validate test coverage for both the OR condition in Insecure initialization and the certificate error handling flow

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Hi @holzman. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holzman
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Thank you for your effort and time on this PR. This one #2134 contains unit test as well. So it is better to move forward with it.

In favor of #2134, closing...
/close

@ardaguclu: Closed this PR.